Skip to content

Conversation

MrShahzebKhoso
Copy link

This PR introduces support for the Audio-Text-to-Text task in huggingface.js.

  • Added details to the sections of the audio-text-to-text task section in the packages/tasks/src/tasks/audio-text-to-text/ directory that contains about.md and data.ts.
  • Ensured consistency with existing task structure and documentation.

Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!
only about.md part needs a bit of changes, we try to keep these pages high quality sources
also cc @Vaibhavs10 if you have time would be nice if you could review!

@MrShahzebKhoso
Copy link
Author

@merveenoyan Thank you very much for the guidance and valuable feedback. I have made all the changes.

  1. Updated inference section. Added 3 different codes that can be run directly. The files are from URLs.
  2. Added the Voxtral Examples in the inference section for more authenticity.
  3. Added more details and more use cases for better understanding.
  4. Added resources section in the about.md file. This contains links to the papers, blogs, datasets, and codes. These will be helpful to anyone trying to explore more.

Kindly let me know if you have any further suggestions. I really appreciate your time and input!

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentle reminder @merveenoyan @MrShahzebKhoso to look at existing open PRs before opening a new one, in this case there was already an old task PR from @Deep-unlearning: #1212

That said, let's proceed with this one since it's from the community vs in-house.

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a first pass, cc: @Deep-unlearning - could you take a look by Monday as well please.

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @Vaibhavs10's comments and the linter changes.

@MrShahzebKhoso
Copy link
Author

Thank you, @Vaibhavs10 and @pcuenca, for reviewing and considering this PR. I’ve made the requested updates and pushed the changes.

  1. Added the two examples from Initial commit: Add task audio-text-to-text #1212.
  2. Updated the resources section with additions from Initial commit: Add task audio-text-to-text #1212.
  3. Revised about.md to align with task documentation standards.
  4. Ensured consistency in formatting and descriptions.

Looking forward to your feedback and approval.

@Deep-unlearning Deep-unlearning self-requested a review September 1, 2025 08:15
@Deep-unlearning
Copy link
Contributor

Hi @MrShahzebKhoso, Thanks a lot!
I added some fixes for grammar and typos. Otherwise LGTM!

@MrShahzebKhoso
Copy link
Author

Hi @Deep-unlearning, thank you for reviewing and the fixes. Really appreciate the support.
I have committed these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants