-
Notifications
You must be signed in to change notification settings - Fork 500
Add audio text to text task #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add audio text to text task #1692
Conversation
…paces, and use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot!
only about.md part needs a bit of changes, we try to keep these pages high quality sources
also cc @Vaibhavs10 if you have time would be nice if you could review!
Co-authored-by: Merve Noyan <[email protected]>
Co-authored-by: Merve Noyan <[email protected]>
Co-authored-by: Merve Noyan <[email protected]>
Co-authored-by: Merve Noyan <[email protected]>
Updated about.md as per the review.
@merveenoyan Thank you very much for the guidance and valuable feedback. I have made all the changes.
Kindly let me know if you have any further suggestions. I really appreciate your time and input! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gentle reminder @merveenoyan @MrShahzebKhoso to look at existing open PRs before opening a new one, in this case there was already an old task PR from @Deep-unlearning: #1212
That said, let's proceed with this one since it's from the community vs in-house.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took a first pass, cc: @Deep-unlearning - could you take a look by Monday as well please.
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @Vaibhavs10's comments and the linter changes.
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
Thank you, @Vaibhavs10 and @pcuenca, for reviewing and considering this PR. I’ve made the requested updates and pushed the changes.
Looking forward to your feedback and approval. |
Hi @MrShahzebKhoso, Thanks a lot! |
Co-authored-by: Steven Zheng <[email protected]>
Co-authored-by: Steven Zheng <[email protected]>
Co-authored-by: Steven Zheng <[email protected]>
Hi @Deep-unlearning, thank you for reviewing and the fixes. Really appreciate the support. |
This PR introduces support for the Audio-Text-to-Text task in huggingface.js.