Skip to content

[Tasks] Add gfxVersion to AMD GPUs in hardware.ts#2011

Open
julien-c wants to merge 1 commit intoadd-compute-capability-nvidia-gpusfrom
add-gfx-version-amd-gpus
Open

[Tasks] Add gfxVersion to AMD GPUs in hardware.ts#2011
julien-c wants to merge 1 commit intoadd-compute-capability-nvidia-gpusfrom
add-gfx-version-amd-gpus

Conversation

@julien-c
Copy link
Member

@julien-c julien-c commented Feb 27, 2026

Summary

Test plan

  • npx tsc --noEmit passes
  • Grep confirms all 24 AMD GPUs have a gfxVersion entry

Note

Low Risk
Low risk: adds a new optional metadata field (gfxVersion) and populates it for AMD GPU SKU entries, with no behavioral or control-flow changes.

Overview
Adds an optional gfxVersion field to HardwareSpec as the AMD counterpart to NVIDIA computeCapability.

Populates gfxVersion across all AMD GPU entries in SKUS (e.g. MI-series and RX-series) to record the corresponding GFX/LLVM ISA target.

Written by Cursor Bugbot for commit a356048. This will update automatically on new commits. Configure here.

Add gfxVersion (GFX target / LLVM ISA) to all 24 AMD GPU entries,
the AMD equivalent of NVIDIA's computeCapability.

Co-Authored-By: Claude <Agents+claude@huggingface.co>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

MI250: {
tflops: 362.1,
memory: [128],
gfxVersion: 9.1,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lossy encoding of gfx90a as numeric gfxVersion 9.1

Medium Severity

The MI250 and MI210 use LLVM target gfx90a, where a is a hex digit. The gfxVersion: 9.1 encoding breaks the implicit bijective mapping that all other entries follow (e.g., 9.42gfx942, 11.01gfx1101). A consumer reconstructing the --offload-arch target from 9.1 would produce gfx910 instead of gfx90a. Using number as the type for gfxVersion makes hex-containing targets like gfx90a inherently lossy — unlike NVIDIA's computeCapability, GFX targets are string identifiers that can contain hex characters.

Additional Locations (2)

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know but i think it might be fine no?

@julien-c julien-c requested a review from mfuntowicz February 27, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant