[Tasks] Add gfxVersion to AMD GPUs in hardware.ts#2011
[Tasks] Add gfxVersion to AMD GPUs in hardware.ts#2011julien-c wants to merge 1 commit intoadd-compute-capability-nvidia-gpusfrom
Conversation
Add gfxVersion (GFX target / LLVM ISA) to all 24 AMD GPU entries, the AMD equivalent of NVIDIA's computeCapability. Co-Authored-By: Claude <Agents+claude@huggingface.co>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| MI250: { | ||
| tflops: 362.1, | ||
| memory: [128], | ||
| gfxVersion: 9.1, |
There was a problem hiding this comment.
Lossy encoding of gfx90a as numeric gfxVersion 9.1
Medium Severity
The MI250 and MI210 use LLVM target gfx90a, where a is a hex digit. The gfxVersion: 9.1 encoding breaks the implicit bijective mapping that all other entries follow (e.g., 9.42 ↔ gfx942, 11.01 ↔ gfx1101). A consumer reconstructing the --offload-arch target from 9.1 would produce gfx910 instead of gfx90a. Using number as the type for gfxVersion makes hex-containing targets like gfx90a inherently lossy — unlike NVIDIA's computeCapability, GFX targets are string identifiers that can contain hex characters.
Additional Locations (2)
There was a problem hiding this comment.
i know but i think it might be fine no?


Summary
gfxVersionoptional field toHardwareSpecinterface — the AMD equivalent of NVIDIA'scomputeCapabilitygfxVersionfor all 24 AMD GPU entries, derived from GFX targets (LLVM ISA)Test plan
npx tsc --noEmitpassesgfxVersionentryNote
Low Risk
Low risk: adds a new optional metadata field (
gfxVersion) and populates it for AMD GPU SKU entries, with no behavioral or control-flow changes.Overview
Adds an optional
gfxVersionfield toHardwareSpecas the AMD counterpart to NVIDIAcomputeCapability.Populates
gfxVersionacross all AMD GPU entries inSKUS(e.g. MI-series and RX-series) to record the corresponding GFX/LLVM ISA target.Written by Cursor Bugbot for commit a356048. This will update automatically on new commits. Configure here.