Update terminology around xorbs and CAS objects.#2024
Open
Conversation
coyotte508
reviewed
Mar 8, 2026
Member
There was a problem hiding this comment.
Comments ok but regarding the WASM update, do you know why the changes? It's also bigger now
Is there any signifcant benefit from the new WASM? (bug fixes/behavior changes impacting chunks / merkle tree / blake3 hash?)
Would be worth running a bench mark - there's huggingface/huggingface.js/packages/xetchunk-wasm/tests/bench.js . Originally it's meant to compare Xet's thin WASM against JS/WASM mix, but it can be run with both old & new thin wasm to compare perf - if it's a perf upgrade
in any case the doc changes on their own are fine, I just don't want to include a bigger wasm in the JS lib without good reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the internal documentation of the xet package to reflect a recent pass to make "xorb" consistently refer to the data objects we use to store chunks, and "cas" consistently refer to the remote server / data store. Previously, both "xorb" and "cas" referred to the data object, which caused some confusion.
Note
Medium Risk
Mostly terminology/comment updates, but the regenerated
chunker_wasm_bg.jschanges wasm-bindgen glue code (externref table indices, added stream adapters), which could affect runtime chunking behavior if mismatched with the wasm module or consumers.Overview
Updates internal Xet terminology to consistently describe stored chunk containers as xorbs (vs previously calling them CAS blocks), including
ReconstructionInfodocs and shard footer field comments inshardParser.ts/uploadShards.ts.Regenerates the vendored wasm-bindgen JS wrapper (
chunker_wasm_bg.js), updating externref table plumbing, adding stream-related adapter classes (IntoUnderlying*), and slightly reshaping the exportedChunkerwrapper (method ordering and new closure/helpers).Written by Cursor Bugbot for commit 3222eae. This will update automatically on new commits. Configure here.