Skip to content

📰 Update about.md #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kadirnar wants to merge 14 commits into
base: main
Choose a base branch
from
Open

📰 Update about.md #456

kadirnar wants to merge 14 commits into from

Conversation

@kadirnar
Copy link

@kadirnar kadirnar commented Jan 25, 2024

Please let's make about.md files more readable. Thanks ❤️

merveenoyan
merveenoyan reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kadirnar
Copy link
Author

kadirnar commented Feb 5, 2024

I did the corrections. I will update other tasks as well. Please don't merge ❤️

@kadirnar
Copy link
Author

kadirnar commented Feb 5, 2024 •
edited
Loading

@merveenoyan Can you check🤩 I updated all tasks related to computer vision.

pcuenca
pcuenca reviewed Feb 5, 2024
View reviewed changes
merveenoyan
merveenoyan reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadirnar thanks a lot for standardizing our docs!!! this is very useful 🤗

merveenoyan
merveenoyan approved these changes Feb 21, 2024
View reviewed changes
@SBrandeis SBrandeis removed their request for review March 29, 2024 14:05
@julien-c
Copy link
Member

julien-c commented Nov 15, 2024

@coyotte508 there are still some remaining TODOs for @kadirnar like https://github.com/huggingface/huggingface.js/pull/456/files#r1497966433 i thnk

@coyotte508
Copy link
Member

coyotte508 commented Nov 15, 2024

@coyotte508 there are still some remaining TODOs for @kadirnar like #456 (files) i thnk

Honestly I have no idea why it did that:

image

I didn't do anything

@julien-c
Copy link
Member

julien-c commented Nov 15, 2024

lol i assumed it was your open-PR OCD 😁

@kadirnar
Copy link
Author

kadirnar commented Nov 18, 2024

@coyotte508 there are still some remaining TODOs for @kadirnar like https://github.com/huggingface/huggingface.js/pull/456/files#r1497966433 i thnk

I removed the device parameter. Is there anything else I need to fix? @merveenoyan , can you check?

@pcuenca
Copy link
Member

pcuenca commented May 12, 2025

@merveenoyan I don't know if there's anything pending here, feel free to merge if / when you think is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcuenca pcuenca pcuenca left review comments

@merveenoyan merveenoyan merveenoyan approved these changes

@osanseviero osanseviero Awaiting requested review from osanseviero

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

@ngxson ngxson Awaiting requested review from ngxson ngxson is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kadirnar @julien-c @coyotte508 @pcuenca @merveenoyan