Skip to content

Conversation

merveenoyan
Copy link
Contributor

@merveenoyan merveenoyan marked this pull request as ready for review September 2, 2024 12:14
@merveenoyan merveenoyan requested a review from pcuenca September 4, 2024 11:08
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter suggestions

@merveenoyan
Copy link
Contributor Author

merveenoyan commented Sep 6, 2024

IDK why linting on my local results in no change but here it fails works now

@merveenoyan
Copy link
Contributor Author

I did another passthrough and couldn't see anything that I'd change, would love an approval if there's no other thing y'all would change here

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a final pass and suggested a couple of minor nits, LGTM 🔥

@merveenoyan merveenoyan merged commit f9aa67d into main Sep 6, 2024
5 checks passed
@merveenoyan merveenoyan deleted the add-vt2t-task-page branch September 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants