Skip to content

Conversation

NielsRogge
Copy link
Contributor

The YOLOv10 author already added library_name: yolov10 into each of his model repos, e.g. https://huggingface.co/jameslahm/yolov10x.

This PR adds a "How to use this model" button along with a code snippet.

cc @jameslahm

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docsUrl: "https://github.com/jasonppy/VoiceCraft",
snippets: snippets.voicecraft,
},
yolov10: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Note that this might impact few dozen repos https://huggingface.co/models?other=yolov10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also impacts quants/ conversions as well.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

yolov10: {
prettyLabel: "YOLOv10",
repoName: "yolov10",
repoUrl: "https://github.com/THU-MIG/yolov10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing for my brain as they install from yolov10 GH repo and then use ultralytics for inference: https://github.com/ultralytics/ultralytics

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes would make more sense to link to https://github.com/ultralytics/ultralytics no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but the code base includes several updates to work directly with the hub.

The Ultralytics repo doesn't support that :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @glenn-jocher wdyt? would be awesome to properly link to Ultralytics implem from model pages on the Hub!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference the PR is here ultralytics/ultralytics#13294

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-c @NielsRogge hi guys, could we set up a call to understand this a little better? https://calendly.com/glenn-jocher/meet

Thanks!

docsUrl: "https://github.com/jasonppy/VoiceCraft",
snippets: snippets.voicecraft,
},
yolov10: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also impacts quants/ conversions as well.

@NielsRogge NielsRogge merged commit 83a9cb6 into huggingface:main Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants