Skip to content

add 3DTopia-XL as library #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 19, 2024
Merged

add 3DTopia-XL as library #910

merged 6 commits into from
Sep 19, 2024

Conversation

@FrozenBurning
Copy link
Contributor

Library name 3dtopia-xl has been added in the repo 3DTopia-XL for 3D generation https://huggingface.co/FrozenBurning/3DTopia-XL

This PR will allow automatic download stats on *.pt files in the repo together with code snippets on how to use them.

Vaibhavs10
Vaibhavs10 reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR. Please make sure to put an actual usage snippet and make sure the mentioned repos are public if not already.

Vaibhavs10
Vaibhavs10 reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FrozenBurning the only thing left to address is this: https://github.com/huggingface/huggingface.js/pull/910/files#r1764862960

@FrozenBurning
Copy link
Contributor Author

Updated! Thanks @Vaibhavs10 !

Vaibhavs10
Vaibhavs10 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and thanks for iterating on this. Let's wait for one more approval before merging! 🤗

Wauplin
Wauplin reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FrozenBurning! Left a couple comments to address :)

FrozenBurning
FrozenBurning commented Sep 19, 2024
View reviewed changes
Copy link
Contributor Author

@FrozenBurning FrozenBurning left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Wauplin ! All updates addressed!

Wauplin
Wauplin approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating! Looks good now :)

@Wauplin Wauplin merged commit 959a182 into huggingface:main Sep 19, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wauplin Wauplin Wauplin approved these changes

@Vaibhavs10 Vaibhavs10 Vaibhavs10 approved these changes

@osanseviero osanseviero Awaiting requested review from osanseviero

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

@pcuenca pcuenca Awaiting requested review from pcuenca pcuenca is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FrozenBurning @Wauplin @Vaibhavs10