[InferenceClient] Manually updating chat_completion()'s params types
#2682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Nov 28, 2024
Contributor
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
Thanks!
IMO it's better to handle InferenceClient.chat_completion() updates manually
Agree!
Comment on lines
+1229
to
+1233
| negative_prompt: Optional[List[str]] = None, | ||
| num_inference_steps: Optional[int] = None, | ||
| guidance_scale: Optional[float] = None, | ||
| model: Optional[str] = None, | ||
| target_size: Optional[ImageToImageTargetSize] = None, |
Contributor
There was a problem hiding this comment.
(nit) worth mentioning this breaking change in the release notes
Contributor
Author
There was a problem hiding this comment.
btw, I did not add a proper deprecation given the possible limited usage of InferenceClient.image_to_image(), but of course, this will be mentioned in the release notes!
Contributor
There was a problem hiding this comment.
yep, no need for a deprecation cycle here 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
InferenceClient.chat_completion()to match the latest (TGI) changes (see: huggingface.js#1030). This is done manually rather than withutils/check_task_parameters.pyscript because chat completion specs are listed in a ChatCompletionInput dataclass, unlike other tasks that use a *Parameters dataclass to list the task parameters.IMO it's better to handle
InferenceClient.chat_completion()updates manually to ensure maximum reliability and avoid adding special cases to theutils/check_task_parameters.pyscript which is already quite clunky.Note: I also discovered a small bug in
utils/check_task_parameters.pyand i added the fix here. Also, this PR should fix some issues in the CI in #2664.