Partial revert #2851: allow task override on sentence-similarity #2861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
thank you!
a bit of context for us in the future: it turns out the numbers show that the feature-extraction API is still used with the sentence-similarity models, so we decided not killing this feature for now. more info in this slack message (internal).
julien-c
approved these changes
Feb 14, 2025
| return f"{self.base_url}/models/{mapped_model}" | ||
| return ( | ||
| # Feature-extraction and sentence-similarity are the only cases where we handle models with several tasks. | ||
| f"{self.base_url}/pipeline/{self.task}/{mapped_model}" |
There was a problem hiding this comment.
note: this URL is probably not super easy to "route" to a specific Pod on the Infra side, but it'd be painful to change it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2851 and huggingface/huggingface.js#1201.
There was a little misunderstanding on what we were trying to achieve 😄