Skip to content

Add Cohere as an Inference Provider #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2025
Merged

Add Cohere as an Inference Provider #2888

merged 6 commits into from
Mar 4, 2025

Conversation

alexrs-cohere
Copy link
Contributor

@alexrs-cohere alexrs-cohere commented Feb 25, 2025 •
edited
Loading

What

Add Cohere as an Inference Provider

What should reviewers focus on?

Is there anything missing in the implementation?

Related to huggingface/huggingface.js#1202

Wauplin
Wauplin approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for putting this back together 🤗
It's ready to be merged. @hanouticelina wanna have a last look at it?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin
Copy link
Contributor

Wauplin commented Feb 27, 2025

Tests are failing because in CI we are using an hf token and therefore HF routing. This means Cohere needs to be an official provider first, before getting into the Python client (the JS part works slightly differently since it is required to make an integration official). We can leave this PR open for now.

hanouticelina
hanouticelina reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @alexrs-cohere for the contribution! I left a small comment, otherwise it looks good to me 🤗

@Wauplin
Copy link
Contributor

Wauplin commented Mar 4, 2025

Merging this as the CI is now green! 😃

@Wauplin Wauplin merged commit c138dc8 into huggingface:main Mar 4, 2025
Wauplin added a commit that referenced this pull request Mar 11, 2025
@alexrs-cohere @Wauplin @hanouticelina
Add Cohere as an Inference Provider (#2888)
ad7950b 
* Add Cohere as an Inference Provider

* Use new Cohere OpenAI compatible API

* Update docs/source/en/guides/inference.md

* Update src/huggingface_hub/inference/_providers/cohere.py

Co-authored-by: Célina <[email protected]>

---------

Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Célina <[email protected]>
@mend-for-github-com mend-for-github-com bot mentioned this pull request Apr 19, 2025
Open
1 task
@renovate renovate bot mentioned this pull request Jun 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wauplin Wauplin Wauplin approved these changes

@hanouticelina hanouticelina hanouticelina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexrs-cohere @HuggingFaceDocBuilderDev @Wauplin @hanouticelina