Conditionally allow request redirection with environment variable #3305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raka-gunarto
force-pushed
the
raka-gunarto/allow-redirects-with-env-var
branch
2 times, most recently
from
4389869 to
5f2febd
Compare
|
This has been tested successfully behind a Cisco Umbrella firewall inserting redirects to opendns.com, can someone please review? |
raka-gunarto
force-pushed
the
raka-gunarto/allow-redirects-with-env-var
branch
from
5f2febd to
47f0cc4
Compare
raka-gunarto
force-pushed
the
raka-gunarto/allow-redirects-with-env-var
branch
from
47f0cc4 to
281d675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you're behind a corporate firewall like Cisco Umbrella which does funny business like adding redirections. Add redirect domain allowlist with environment variable.
Example use: