Use git xet transfer to check if xet is enabled #3381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanouticelina
commented
Sep 23, 2025
Comment on lines
-317
to
+366
| class TestXetE2E(TestXetUpload): | ||
| @pytest.mark.usefixtures("xet_setup") | ||
| class TestXetE2E: |
There was a problem hiding this comment.
Unrelated to the PR but i realized we were running TestXetUpload twice with this inheritance 🙃 fixed it here
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Sep 23, 2025
| # - the files are provided as str or paths objects, | ||
| # - the library is installed. | ||
| # Otherwise, default back to LFS. | ||
| xet_enabled = self.repo_info( |
There was a problem hiding this comment.
all of this to remove this call 😄
|
|
||
|
|
||
| @pytest.fixture | ||
| def xet_setup(request, tmp_path): |
Co-authored-by: Lucain <[email protected]>
…e/huggingface_hub into use-xet-transfer-in-lfs-calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/huggingface-internal/moon-landing/pull/14572 (private) and huggingface/huggingface.js#1761.
This PR removes the client-side check to
/api/{repo_type}s/{repo_id}?expand[]=xetEnabledto know if xet is enabled when uploading, transfer selection is now determined by the server via the Git LFS Batch API. the negotiated transfer (basic, multipart or xet) is known only once we've queried the batch API. the client tells the server when xet is supported (if hf-xet is available, the input is not a BytesIO, and HF_HUB_DISABLE_XET is not set to 1.