Require filelock>=3.10.0 for mode= parameter support#3785
Open
Require filelock>=3.10.0 for mode= parameter support#3785
mode= parameter support#3785Conversation
The `mode=` parameter used in `WeakFileLock` was added in filelock 3.10.0. Pin the minimum version to avoid crashes with older versions. Fixes #3777 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
(let's wait for confirmation from #3777 before merging) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mode=parameter used inWeakFileLockwas added in filelock 3.10.0 released in 03-2023. Pin the minimum version to avoid crashes with older versions.Fixes #3777
(follow up PR after #3714 which introduced the
mode=kwarg)Note
Low Risk
Only changes a dependency lower bound; risk is limited to potential compatibility impacts for environments pinned to older
filelockversions.Overview
Prevents runtime failures on older
filelockreleases by raising the minimum required version insetup.pyfrom unpinnedfilelocktofilelock>=3.10.0, ensuring support for themode=argument used byWeakFileLock.Written by Cursor Bugbot for commit 80b22a2. This will update automatically on new commits. Configure here.