Terminate timeout vus immediately instead of waiting it to finish#33
Open
CoderOJ wants to merge 1 commit intohuggingface:mainfrom
Open
Terminate timeout vus immediately instead of waiting it to finish#33CoderOJ wants to merge 1 commit intohuggingface:mainfrom
CoderOJ wants to merge 1 commit intohuggingface:mainfrom
Conversation
CoderOJ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the executor reaches the configured duration, some requests are not interrupted, extending the actual benchmark run time. During this extra time, VUs gradually decreases, reducing the server’s batch size, and thus decreases throughput.
Therefore, in constant VUs mode, I've made all requests terminat immediately at timeout, so as to improve benchmark stability.
For constant arrival rate mode, I'm not certain if the above change is appropriate, so I left it unchanged.