Append the endpoint path to the base_url instead of replacing the path#35
Open
fabienric wants to merge 1 commit intohuggingface:mainfrom
Open
Append the endpoint path to the base_url instead of replacing the path#35fabienric wants to merge 1 commit intohuggingface:mainfrom
fabienric wants to merge 1 commit intohuggingface:mainfrom
Conversation
…ase_url path instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm testing the tool to benchmark an endpoint that is OpenAI-compatible but where the routes are behind a path, for example
https://myendpoint.com/api/openai_compat/v1/chat/completions.Currently, when I pass the url
https://myendpoint.com/api/openai_compatin the CLI, the endpoint path overrides the existing path, so the tool callshttps://myendpoint.com/v1/chat/completionswhich is not available.This change appends the endpoint path to the base url instead of replacing it, enabling my use case.