Skip to content

fix: Fix results dashboard#6

Merged
Hugoch merged 6 commits intomainfrom
fix/results-dashboard
Mar 28, 2025
Merged

fix: Fix results dashboard#6
Hugoch merged 6 commits intomainfrom
fix/results-dashboard

Conversation

@Hugoch
Copy link
Member

@Hugoch Hugoch commented Mar 27, 2025

Fix Gradio results dashboard. Fixes #5

@Hugoch Hugoch self-assigned this Mar 27, 2025
@Hugoch Hugoch requested a review from Copilot March 27, 2025 18:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the results dashboard for the Inference Benchmarker by adding a new run identifier and updating various configuration and dependency files. Key changes include:

  • Adding a new "run_id" field to the command-line arguments and propagating it through configuration structures.
  • Bumping package versions (e.g. gradio, matplotlib, pyarrow) and updating Cargo.toml metadata.
  • Removing obsolete files (optimum.py and plot.py) and refactoring the Gradio dashboard logic.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main.rs Introduces a new run_id, generated via a UUID slice, into Args.
src/lib.rs Propagates the new run_id in the RunConfiguration.
src/benchmark.rs Adds run_id (and model_name) to BenchmarkConfig and tests.
pyproject.toml Updates package version and dependency versions.
optimum.py, extra/plots/plot.py Removes unused files.
extra/dashboard/*.py Updates parsing and dashboard logic to use the new run_id field.
Cargo.toml Updates project metadata and version, and defines the binary.
README.md Adjusts documentation text for clarity.

@Hugoch Hugoch merged commit 0ff411a into main Mar 28, 2025
5 checks passed
@TheRValiquette
Copy link

Sorry to use this PR to communicate with you but I was wondering if there was a place or forum where we can discus about inference-benchmark project?

@Hugoch
Copy link
Member Author

Hugoch commented Apr 15, 2025

@TheRValiquette , I think you can use a Github issue for that and we can flag it as a question ?

@TheRValiquette
Copy link

Great! Thank you for the quick feedback. I created a Github issue for it :
#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: argument of type 'NoneType' is not iterable

3 participants