Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the results dashboard for the Inference Benchmarker by adding a new run identifier and updating various configuration and dependency files. Key changes include:
- Adding a new "run_id" field to the command-line arguments and propagating it through configuration structures.
- Bumping package versions (e.g. gradio, matplotlib, pyarrow) and updating Cargo.toml metadata.
- Removing obsolete files (optimum.py and plot.py) and refactoring the Gradio dashboard logic.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Introduces a new run_id, generated via a UUID slice, into Args. |
| src/lib.rs | Propagates the new run_id in the RunConfiguration. |
| src/benchmark.rs | Adds run_id (and model_name) to BenchmarkConfig and tests. |
| pyproject.toml | Updates package version and dependency versions. |
| optimum.py, extra/plots/plot.py | Removes unused files. |
| extra/dashboard/*.py | Updates parsing and dashboard logic to use the new run_id field. |
| Cargo.toml | Updates project metadata and version, and defines the binary. |
| README.md | Adjusts documentation text for clarity. |
|
Sorry to use this PR to communicate with you but I was wondering if there was a place or forum where we can discus about inference-benchmark project? |
Member
Author
|
@TheRValiquette , I think you can use a Github issue for that and we can flag it as a question ? |
|
Great! Thank you for the quick feedback. I created a Github issue for it : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Gradio results dashboard. Fixes #5