This repository was archived by the owner on Jan 27, 2026. It is now read-only.
fix(build2cmake): ignore untracked files when looking for modified files to suffix with _dirty#280
Merged
mfuntowicz merged 1 commit intomainfrom Oct 29, 2025
Conversation
…les to suffix with `_dirty`
danieldk
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current flow,
build2cmakemight generatesCMakefiles before this get called thus generating some changes (i.e.statuses.is_empty() == falseif the build folder is in the source tree.Adding options in order to soften a bit the constraint