Fix MPS encoder lifecycle in relu-metal-cpp example#316
Draft
robtaylor wants to merge 1 commit intohuggingface:mainfrom
Draft
Fix MPS encoder lifecycle in relu-metal-cpp example#316robtaylor wants to merge 1 commit intohuggingface:mainfrom
robtaylor wants to merge 1 commit intohuggingface:mainfrom
Conversation
6 tasks
Add C bridge functions (getMPSCommandEncoder, mpsSynchronize, mpsDispatchSync) to metallib_loader.mm so the C++ metal-cpp example can properly integrate with PyTorch's MPS stream encoder lifecycle without needing ObjC++ code in the main kernel file. Co-developed-by: Claude Code v2.1.50 (claude-opus-4-6)
robtaylor
force-pushed
the
fix-relu-metal-cpp-lifecycle
branch
from
2b1cafd to
8bca140
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getMPSCommandEncoder,mpsSynchronize,mpsDispatchSync) tometallib_loader.mmso the C++ metal-cpp example properly integrates with PyTorch's MPS stream encoder lifecyclerelu.cppto use the bridge functions instead of creating encoders directly, which bypasses PyTorch's kernel coalescing and crashes on sequential kernel callsThis is the metal-cpp companion to #308 (which fixes the ObjC++ path). The same MPS encoder lifecycle issue affects the C++ example — direct
[commandBuffer computeCommandEncoder]usage crashes when multiple kernels are dispatched sequentially.Test plan
Co-developed-by: Claude Code (claude-opus-4-6)