Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
danieldk
previously approved these changes
Mar 11, 2026
Member
danieldk
left a comment
danieldk
left a comment
There was a problem hiding this comment.
Looks great, one tiny minor nit. Feel free to merge!
kernels/tests/test_variants.py
Outdated
|
|
||
| def test_xpu_returns_single_variant(self): | ||
| backend = XPU(version=Version("2024.2")) | ||
| assert _compatible_backend_variants(backend) == [backend.variant] |
Member
There was a problem hiding this comment.
Probably best to put a literal here as well on the RHS of the equality check?
Member
Author
|
@danieldk I updated to using literal. But I need another approval for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326
Should we document it somewhere?