Skip to content

Add Filipino Benchmark Community Tasks #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

ljvmiranda921
Copy link

@ljvmiranda921 ljvmiranda921 commented Jul 7, 2025

Hi! Here's our working PR for porting our changes from our own fork filbench/lighteval into HuggingFace's official community tasks :)

@ljvmiranda921 ljvmiranda921 marked this pull request as ready for review July 7, 2025 19:15
@NathanHB NathanHB requested a review from Copilot July 9, 2025 13:35
Copilot

This comment was marked as outdated.

Copy link
Member

@NathanHB NathanHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

started reviewing, i'm launching to evals to make sure all is good so i will come back to you once it's ready. Otherwise very great job, the PR looks great !

@ljvmiranda921
Copy link
Author

Thanks so much for the review! 👍 I have already updated and fixed the errors :)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ports Filipino benchmark tasks into the HuggingFace community tasks, adding language-specific literals, a task manifest, and the full set of Filipino task configurations.

  • Added custom translation literals for Cebuano and Tagalog
  • Introduced an example manifest listing all Filipino community tasks
  • Added a new filipino_evals.py module defining all Filipino task configs

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/lighteval/tasks/templates/utils/translation_literals.py Added TranslationLiterals entries for Cebuano and Tagalog
examples/tasks/all_filipino_tasks.txt New file listing Filipino community tasks
community_tasks/filipino_evals.py Added Filipino task definitions across various categories
Comments suppressed due to low confidence (2)

examples/tasks/all_filipino_tasks.txt:1

  • The file appears to include literal line numbers and '+' prefixes in each line, which will break downstream parsers. Remove the leading numbers and '+' characters so each line only contains the task identifier (e.g. community|readability_ceb_mcf|0|0).
community|readability_ceb_mcf|0|0

community_tasks/filipino_evals.py:1

  • [nitpick] This module is very large (~800 lines) and houses many task definitions. Consider splitting tasks into category-specific submodules or separate files to improve readability and maintainability.
# MIT License

@ljvmiranda921
Copy link
Author

Hi @NathanHB ! Just a gentle nudge if there's anything we need to do on our end for this to be merged?

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@NathanHB NathanHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey ! Sorry for the late review I just came back from vacation. Everything looks great, thanks for fixing the issues :)

@ljvmiranda921
Copy link
Author

Yay thank you so much @NathanHB for the awesome review process as well 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants