Support local GGUF in VLLM and use HF tokenizer #943#972
Merged
NathanHB merged 2 commits intohuggingface:mainfrom Sep 18, 2025
Merged
Support local GGUF in VLLM and use HF tokenizer #943#972NathanHB merged 2 commits intohuggingface:mainfrom
NathanHB merged 2 commits intohuggingface:mainfrom
Conversation
NathanHB
reviewed
Sep 17, 2025
Comment on lines
+295
to
+297
| config.tokenizer | ||
| if config.tokenizer | ||
| else config.model_name, # use HF tokenizer for non-HF models, like GGUF model. |
Member
There was a problem hiding this comment.
using config.tokenizer or config.model_name would be better here
Contributor
Author
There was a problem hiding this comment.
Thank you for the suggestion, I've updated the implementation
NathanHB
reviewed
Sep 17, 2025
NathanHB
approved these changes
Sep 18, 2025
Collaborator
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
Because VLLM have already supported local GGUF file, and the enforce_eager is fix to True, all we need to do is use HF tokenizer for local GGUF in inference. (As mentioned in the VLLM document)

And here is the example of local GGUF in VLLM document

I test the following scripts for VLLM model in GGUF format
And the log and evaluation results are attached as follow.
results_2025-09-17T14-36-32.075650.json
Please help to review,
Thank you,
Eli Chen