docs(notebook): sync config and update README links (fixes #144)#193
Open
FazeelUsmani wants to merge 1 commit intohuggingface:mainfrom
Open
docs(notebook): sync config and update README links (fixes #144)#193FazeelUsmani wants to merge 1 commit intohuggingface:mainfrom
FazeelUsmani wants to merge 1 commit intohuggingface:mainfrom
Conversation
…e#144) - Verify train_nanoVLM.ipynb VLMConfig matches models/config.py - Update README.md links from nanoVLM.ipynb to train_nanoVLM.ipynb - Add validation cell to demonstrate model save/load compatibility The lm_eos_token_id field was removed from the library in PR huggingface#138 (July 2025) and subsequently removed from the notebook when it was renamed from nanoVLM.ipynb to train_nanoVLM.ipynb in commit 9de5e17 (Sept 2025). This PR formally resolves huggingface#144 by confirming the sync is complete and updating stale documentation references. Changes: - README.md: Update Colab badge and interactive notebook links (lines 5, 42) - train_nanoVLM.ipynb: Add validation cells to verify from_pretrained() works Fixes huggingface#144
Author
|
Please review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves issue #144 by confirming the notebook configuration is synchronized with the library and updating stale documentation links.
Changes
train_nanoVLM.ipynbVLMConfig matchesmodels/config.py(nolm_eos_token_id)nanoVLM.ipynb→train_nanoVLM.ipynb(lines 5, 42)Context
Issue #144 was opened on July 9, 2025, reporting that the notebook's VLMConfig included
lm_eos_token_id, which had been removed from the library in PR #138 (July 3, 2025).The field was subsequently removed from the notebook when it was renamed from
nanoVLM.ipynbtotrain_nanoVLM.ipynbin commit 9de5e17 (Sept 10, 2025), but:Testing
Notes
Closes #144