Skip to content

Conversation

@ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Nov 16, 2024

What does this PR do?

I've created 4 New Notebooks for Diffuser Community Scripts, same as #525. After this PR gets merged, I will update the Colab column in the ReadMe.

Please let me know if any improvements are needed and I will make the necessary changes.

Reference: https://github.com/huggingface/diffusers/blob/main/examples/community/README.md

Who can review?

@stevhliu

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Nov 18, 2024

View / edit / reply to this conversation on ReviewNB

stevhliu commented on 2024-11-18T15:55:36Z
----------------------------------------------------------------

Would also be nice to include the parameters and what they do as shown in https://github.com/huggingface/diffusers/blob/main/examples/community/README.md#demofusion.


Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding notebooks where there are currently none!

@ParagEkbote
Copy link
Contributor Author

I have updated the notebooks as per given feedback.

Could you please review?

cc: @stevhliu

@ParagEkbote ParagEkbote requested a review from stevhliu November 18, 2024 17:07
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevhliu stevhliu merged commit f1b7f5b into huggingface:main Nov 18, 2024
@ParagEkbote ParagEkbote deleted the Notebooks-for-community-scripts-2 branch November 19, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants