Skip to content

Address comments on #158 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Address comments on #158 #159

wants to merge 3 commits into from

Conversation

@larryliu0820
Copy link
Collaborator

  • Moved attention check earlier
  • Check for .ptd file as well in unit test

@larryliu0820
Address comments on #158
2ca61ed 
* Moved attention check earlier
* Check for .ptd file as well in unit test
mergennachin
mergennachin approved these changes Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my reply here https://github.com/huggingface/optimum-executorch/pull/158/files#r2403419621

jackzhxng
jackzhxng approved these changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we gonna merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

@jackzhxng jackzhxng jackzhxng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larryliu0820 @mergennachin @jackzhxng