Conversation
38ad113 to
5d1a70d
Compare
|
observing regression after rebase. Need to fix the regression. |
dsocek
left a comment
There was a problem hiding this comment.
Looks good, small fix suggested to add HPU centric example doc string
optimum/habana/diffusers/pipelines/qwenimage/pipeline_qwenimage.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Could we do this monkey patching directly in the __init__ of the GaudiDiffusionPipeline?
There was a problem hiding this comment.
I added like below, but didn't work.
from ..models.transformers import ( GaudiQwenTimestepProjEmbeddings, GaudiQwenEmbedRope, GaudiQwenDoubleStreamAttnProcessor2_0 ) diffusers.models.transformers.transformer_qwenimage.QwenTimestepProjEmbeddings = GaudiQwenTimestepProjEmbeddings diffusers.models.transformers.transformer_qwenimage.QwenEmbedRope = GaudiQwenEmbedRope diffusers.models.transformers.transformer_qwenimage.QwenDoubleStreamAttnProcessor2_0 = GaudiQwenDoubleStreamAttnProcessor2_0
There was a problem hiding this comment.
monkey patch doesn't work in __init__ but from_pretrained() of the GaudiDiffusionPipeline. Placed it in from_pretrained().
There was a problem hiding this comment.
Sounds good, thanks for looking further into it!
4a1a5be to
b0a635d
Compare
|
The code quality check failed, please run |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
regisss
left a comment
There was a problem hiding this comment.
I left one more comment to basically move all the logic in modeling_utils.py to the from_pretrained method.
Also, the code style check failed, please run
make style
from the root of the repo.
Enable qwen-image with Gaudi specific optimization. Rewrite RoPE from complex to cos/sin.
Enable qwen-image with Gaudi specific optimization. Rewrite RoPE from complex to cos/sin.
What does this PR do?
Fixes # (issue)
Before submitting