Fix null handling when padding optional negative prompt batches#2357
Merged
regisss merged 1 commit intohuggingface:mainfrom Dec 22, 2025
Merged
Conversation
Collaborator
Author
|
@regisss please also merge this PR into the v1.21-release branch |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
regisss
pushed a commit
that referenced
this pull request
Dec 22, 2025
Collaborator
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a runtime crash when batching inputs where negative_prompt_embeds or its mask is not provided.
The update was required by the Coverity static analysis tool, which correctly detected a possible null dereference in the padding logic.