Fix mxeval installation in mbxp_evaluation setup#2367
Merged
astachowiczhabana merged 1 commit intohuggingface:v1.21-releasefrom Feb 23, 2026
Merged
Conversation
|
The code quality check failed, please run |
The mxeval package was failing to install due to two issues with newer pip/setuptools versions: 1. pkg_resources has been removed from setuptools>=82. When pip uses build isolation (default), it installs latest setuptools which no longer includes pkg_resources, causing mxeval setup.py to fail. 2. The entry_point in mxeval setup.py is missing the required callable suffix (:main), which newer pip versions enforce. Fix by: - Pinning mxeval to a known-good commit (e09974f) - Patching the broken entry_point after cloning - Using --no-build-isolation to use existing setuptools
astachowiczhabana
force-pushed
the
fix-mxeval-installation
branch
from
602b374 to
b1c4eb3
Compare
astachowiczhabana
requested review from
libinta,
mandy-li and
vivekgoe
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mixtral evaluation models are crashing with
ModuleNotFoundError: No module named 'mxeval.execution'.The
mxevalpackage fails to install duringmbxp_evaluation/setup.shexecution due to two issues with newer pip/setuptools versions:pkg_resourcesremoved fromsetuptools>=82:mxeval/setup.pyusesimport pkg_resources, which has been removed. Whenpip install -e mxevalruns with build isolation (default), pip creates an isolated build environment with the latestsetuptoolswhich no longer includespkg_resources.Invalid
entry_pointformat:mxeval/setup.pydeclares an entry point without the required callable suffix (:main), which newer pip versions enforce strictly.Fix
mxevalto a known-good commit (e09974f)entry_pointinmxeval/setup.pyafter cloning--no-build-isolationto avoid thepkg_resourcesissueFixes: GAUDISW-246483