Skip to content

Conversation

@mvafin
Copy link
Contributor

@mvafin mvafin commented Jun 9, 2025

What does this PR do?

Add support for bitnet models.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@mvafin mvafin force-pushed the mvafin/bitnet_support branch from 008bc8b to a3b91d2 Compare June 9, 2025 13:31
@mvafin mvafin changed the title Mvafin/bitnet support Support bitnet models Jun 9, 2025
@echarlaix
Copy link
Collaborator

@bot /style

@github-actions
Copy link

Style fixes have been applied. View the workflow run here.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@mvafin mvafin force-pushed the mvafin/bitnet_support branch from cae06e8 to 5c526a2 Compare August 12, 2025 14:45
@mvafin mvafin marked this pull request as ready for review August 13, 2025 16:39
@mvafin
Copy link
Contributor Author

mvafin commented Aug 13, 2025

@IlyasMoutawwakil could you help with testing this? I wanted to use awq or gptq models as reference, but are they tested?
I see the test tests/openvino/test_modeling.py::OVModelForCausalLMIntegrationTest::test_compare_to_transformers, but it fails for me locally, does it work in regular validation?

@IlyasMoutawwakil
Copy link
Member

does it work in regular validation?

yes the awq/gptq tests pass usually.

@mvafin
Copy link
Contributor Author

mvafin commented Aug 19, 2025

@IlyasMoutawwakil Thanks for confirmation, I had issues with package versions locally.

@mvafin
Copy link
Contributor Author

mvafin commented Aug 19, 2025

@bot /style

@nikita-savelyevv
Copy link
Collaborator

@bot /style

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

Style bot fixed some files and pushed the changes.

@IlyasMoutawwakil
Copy link
Member

I see that the bitnet test are conditioned on an openvino version that's still not released, did it work with nightly ?

@mvafin
Copy link
Contributor Author

mvafin commented Aug 21, 2025

@IlyasMoutawwakil It succeeds for me locally, can we run tests on nightly for CI? If I remember correctly there is a flag for this

@IlyasMoutawwakil
Copy link
Member

@mvafin yes they are currently running

@mvafin
Copy link
Contributor Author

mvafin commented Aug 27, 2025

bitnet support on CPU is still WIP.

@mvafin mvafin marked this pull request as draft August 27, 2025 09:45
@mvafin mvafin marked this pull request as ready for review October 22, 2025 10:09
@mvafin
Copy link
Contributor Author

mvafin commented Oct 22, 2025

@IlyasMoutawwakil could you start tests here? Bitnet should work now with nightly openvino

@nikita-savelyevv
Copy link
Collaborator

@mvafin OpenVINO 2025.3 is installed in tests by default, you can temporarily update the https://github.com/huggingface/optimum-intel/blob/main/.github/workflows/test_openvino.yml workflow to install openvino-nightly

@mvafin
Copy link
Contributor Author

mvafin commented Oct 24, 2025

@mvafin OpenVINO 2025.3 is installed in tests by default, you can temporarily update the https://github.com/huggingface/optimum-intel/blob/main/.github/workflows/test_openvino.yml workflow to install openvino-nightly

@nikita-savelyevv Is openvino-test label no longer works for such purpose?

@nikita-savelyevv nikita-savelyevv added the openvino-nightly Runs OpenVINO nightly and NNCF develop tests label Oct 24, 2025
@nikita-savelyevv
Copy link
Collaborator

nikita-savelyevv commented Oct 24, 2025

@mvafin OpenVINO 2025.3 is installed in tests by default, you can temporarily update the https://github.com/huggingface/optimum-intel/blob/main/.github/workflows/test_openvino.yml workflow to install openvino-nightly

@nikita-savelyevv Is openvino-test label no longer works for such purpose?

There is openvino-nightly label for that now. It will run on a larger scope though, potentially resulting in possible issues with connection to HF hub (too many requests at the same time from the same CI token). But we can try.

@nikita-savelyevv
Copy link
Collaborator

@bot /style

@github-actions
Copy link

Style fix is beginning .... View the workflow run here.

@mvafin
Copy link
Contributor Author

mvafin commented Oct 30, 2025

@nikita-savelyevv @IlyasMoutawwakil The failures doesn't seem to be connected with changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openvino-nightly Runs OpenVINO nightly and NNCF develop tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants