use max_length to replace max_seq_length; correct README for
#2862
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delora_finetuning Signed-off-by: Liu, Kaixuan <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…for" This reverts commit 7a7fb87.
Signed-off-by: Liu, Kaixuan <[email protected]>
|
@BenjaminBossan recent version trl/transformers use |
BenjaminBossan
requested changes
Oct 23, 2025
examples/sft/train.py
Outdated
| metadata={"help": "Path to pretrained model or model identifier from huggingface.co/models"} | ||
| ) | ||
| max_seq_length: Optional[int] = field( | ||
| max_length: Optional[int] = field( |
There was a problem hiding this comment.
This change isn't enough, because there is a conflicting argument with the same name. I already took care of that in #2857, so you can revert this change here.
There was a problem hiding this comment.
Oops, I changed the code here by mistake. Yes, for sft case, we should take more actions. Have reverted.
Signed-off-by: Liu, Kaixuan <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delora_finetuning