Implement labels argument for create_dataset (and downstream functions)#2418
Open
JosuaRieder wants to merge 1 commit intohuggingface:mainfrom
Open
Implement labels argument for create_dataset (and downstream functions)#2418JosuaRieder wants to merge 1 commit intohuggingface:mainfrom
JosuaRieder wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for providing the labels with a json file for the "Folder" dataset. Support for other file formats could also be added easily.
I train on pseudo-labels and having to realize the pseudo-labeling using the file system is very slow.
It was not entirely clear to me at which level I should load the actual file, i.e. when to convert the
Union[Dict, str]toDict. I decided oncreate_readerbut it could theoretically also be done one level later, i.e. infind_images_and_targets.