Make SafetensorError pickle-able (fixes #684)#704
Open
jayzuccarelli wants to merge 1 commit intohuggingface:mainfrom
Open
Make SafetensorError pickle-able (fixes #684)#704jayzuccarelli wants to merge 1 commit intohuggingface:mainfrom
jayzuccarelli wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #684
Problem:
SafetensorErroris defined in the Rust extension (_safetensors_rust), sopickle.dumps(SafetensorError())fails (e.g. "Can't pickle: import of module 'safetensors_rust' failed"). Many integrations (multiprocessing, joblib, distributed workers) expect exceptions to be picklable.Solution: Introduce a Python subclass of the Rust
SafetensorErrorthat implements__reduce__, and export it asSafetensorError. Exceptions raised from Rust are still caught byexcept SafetensorError(same type hierarchy). Pickling/unpickling now uses the Python class, so the Rust module is not required when unpickling.bindings/python/py_src/safetensors/__init__.py: PythonSafetensorErrorsubclass with__reduce__(self) -> (SafetensorError, self.args).bindings/python/tests/test_safetensor_error_pickle.py: Tests for pickle round-trip (empty and with message).