add multiprocessing support for Cross Encoder #3580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3350
Implemented 4 functions to support multiprocessing, exactly as done in
SentenceTransformer.pystart_multi_process_pool- same as beforestop_multi_process_pool- same as before_predict_multi_process- similar to_encode_multi_process_predict_multi_process_worker- similar to_encode_multi_process_workerSo far, multiprocessing support has been added to both
predictandrankmethods ofCrossEncoder.py.I've included code for raising Error if any of the worker processes result in an error. Can remove this after testing.
I've tested this on
macOS, but need to test on Colab GPU and confirm.@tomaarsen some functions like
_encode_multi_process_workerand_encode_multi_processdo not have docstrings and params. Should I add them in this PR itself?