Skip to content

candle upgrade to 0.9.2alpha2 #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
michaelfeil wants to merge 6 commits into
base: main
Choose a base branch
from
Open

candle upgrade to 0.9.2alpha2 #784

michaelfeil wants to merge 6 commits into from

Conversation

@michaelfeil
Copy link
Contributor

@michaelfeil michaelfeil commented Dec 22, 2025 •
edited
Loading

  • upgrades candle to latest rc
  • I feel like ~5% overall improvements in performance.

https://github.com/michaelfeil/candle-extensions-fork -> Can be PR'ed and merged into huggingface's candle fork.

@alvarobartt alvarobartt self-requested a review December 22, 2025 15:29
@alvarobartt alvarobartt added this to the v1.9.0 milestone Dec 22, 2025
@michaelfeil michaelfeil changed the title Mf/new candle candle upgrade to 0.9.2rc2 Dec 28, 2025
@michaelfeil michaelfeil changed the title candle upgrade to 0.9.2rc2 candle upgrade to 0.9.2alpha2 Dec 28, 2025
@michaelfeil
Copy link
Contributor Author

michaelfeil commented Jan 2, 2026

There is some issue with the static-linking feature. It seems like some crates are requesting dynamic-linking by default. Once we are selecting static-linking inside this repo, but some external crates select dynamically-linking, we have a cudarc both dynamically and statically linked, which is not allowed.

@vrdn-23 vrdn-23 mentioned this pull request Jan 6, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvarobartt alvarobartt Awaiting requested review from alvarobartt

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelfeil @alvarobartt