-
Notifications
You must be signed in to change notification settings - Fork 349
Add experimental BF16 support for Metal and CUDA #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alvarobartt
wants to merge
21
commits into
main
Choose a base branch
from
add-bfloat16-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This is due to the recent version bump on `tokenizers` from 0.21.1 to 0.21.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds experimental support for BF16 as a supported dtype on both Metal and CUDA, when the features
metalandcudaare enabled, respectively. Ascandlenatively supports BF16, and some recent models as https://huggingface.co/voyageai/voyage-4-nano (and all the other Voyage AI embedding models) default to BF16; support has been introduced to support such cases.Warning
Support for BF16 is still experimental on both Metal and CUDA, whilst stable for Intel HPUs under the
pythonfeature, as it runs with a Python-based backend.Additionally, this PR also updates the Rust version to 1.92.0 (latest stable) in
rust-toolchain.toml, and removes thehalfcrate as a dependency.Before submitting
instasnapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.