Mark Python tests that need network access#1872
Mark Python tests that need network access#1872gordonmessmer wants to merge 1 commit intohuggingface:mainfrom
Conversation
ArthurZucker
left a comment
There was a problem hiding this comment.
Hey! Not super sure this is very important, will leave it as is
|
Please consider marking tests that need network access so that they can be disabled easily. In Fedora and related distributions, packages are built without network access to ensure that the source code provided is the only information required to produce the binary build artifact. SLSA Build Level 4 is likely to specify hermetic builds as a secure build practice, in the future (as early drafts did). https://slsa.dev/spec/v1.2/future-directions |
61f332d to
41d8af8
Compare
|
I would also like to ask for this change to be implemented. It would simplify CI/CD in cases when network access is limited, for example for security reasons. Furthermore, it wouldn't impact experience of developers in situations when that is not the case. |
|
sur, feel free to rebase fix conflicts! |
41d8af8 to
fea4d79
Compare
|
I've rebased on main and tested a variant of this patch against 0.22.2 for a networkless build. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
I would like to mark tests that need network access in order to more easily disable them when building the software in an environment that restricts network access.
I'll mark this PR a draft while I try to determine which other tests require network access.