Merged
Conversation
This was referenced Nov 30, 2025
ArthurZucker
approved these changes
Dec 1, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM
Is my understanding correct that with pyo3 0.26, building for py<3.14 will still work?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
Yes, we still support python 3.7+. I'll fix the lint failures ASAP, probably later today. |
Contributor
Author
|
Lints fixed in 78af191 |
ngoldbaum
approved these changes
Dec 1, 2025
Contributor
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step towards getting tokenizers working on Python 3.14 free-threading.
This PR bumps PyO3 to 0.26. There are three major deprecations in this release, which cleaned up a bunch of PyO3 APIs to remove the "gil" association (which free-threading doesn't have). Each is carried out as a separate commit; in the final commit removing the
PyObjecttype alias forPy<PyAny>I happened upon a number of bits of code which had obvious simplifications. I applied those at the same time.