Skip to content

Fix unclosed annotation span in EncodingVisualizer #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurZucker merged 1 commit into from
Dec 16, 2025
+5 −0
Merged

Fix unclosed annotation span in EncodingVisualizer #1911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bindings/python/py_src/tokenizers/tools/visualizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,11 @@ def __make_html(text: str, encoding: Encoding, annotations: AnnotationList) -> s
encoding=encoding,
)
)

# Close any remaining open annotation span
if cur_anno_ix is not None:
spans.append("</span>")

res = HTMLBody(spans) # Send the list of spans to the body of our html
return res

Expand Down
Loading