Temperature zero issue #1431
Merged
Temperature zero issue #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
xenova
requested changes
Oct 3, 2025
Collaborator
xenova
left a comment
xenova
left a comment
There was a problem hiding this comment.
Thanks! This is the correct place to place the changes and now temperature: 0 will work correctly, even if do_sample: true is set by the user or default in the generation config.
Thanks!
just some wording choices in the warn message, but otherwise good to go.
Collaborator
There was a problem hiding this comment.
we can remove this file -- all examples will be moved to https://github.com/huggingface/transformers.js-examples in transformers.js v4, so this folder will be deleted
5 tasks
Co-authored-by: Joshua Lochner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a check that sets
generation_config.do_sampletofalseiftemperature=0