Skip to content

Conversation

@philkuz
Copy link
Contributor

@philkuz philkuz commented Oct 30, 2024

What does this PR do?

Fixes slow tests that are broken in main and discovered in this PR: #34103

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qubvel

@qubvel
Copy link
Contributor

qubvel commented Oct 30, 2024

@philkuz run-slow commit should be after the run-slow label is added, can you please push it once again?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@philkuz philkuz force-pushed the philkuz/fix_depth_tests branch from 0510da7 to 771d51e Compare October 30, 2024 23:16
@philkuz
Copy link
Contributor Author

philkuz commented Oct 31, 2024

@philkuz run-slow commit should be after the run-slow label is added, can you please push it once again?

Done!

Copy link
Contributor

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! The tests are green now!
cc @ydshieh for tests change

@qubvel qubvel added Tests Related to tests Vision labels Oct 31, 2024
@ydshieh
Copy link
Collaborator

ydshieh commented Oct 31, 2024

Yes, great!

(And thank you for requesting/triggering the slow tests!)

@ydshieh ydshieh merged commit b5919e1 into huggingface:main Oct 31, 2024
20 checks passed
@philkuz
Copy link
Contributor Author

philkuz commented Oct 31, 2024 via email

BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…e tests (huggingface#34518)

* fix(DPT,Depth-Anything) Address expected_slice errors inside inference tests

Signed-off-by: Phillip Kuznetsov <[email protected]>

* [run_slow] dpt, depth_anything

---------

Signed-off-by: Phillip Kuznetsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants