Modular Conversion --fix_and_overwrite on Windows

[hlky]

What does this PR do?

Uses encoding="utf-8" and newline="\n"

FYI huggingface_hub introduced a style bot GitHub action huggingface/huggingface_hub#2898 we're using that in Diffusers https://github.com/huggingface/diffusers/blob/main/.github/workflows/pr_style_bot.yml to reduce the burden on external contributors.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

[github-actions]

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[Rocketknight1]

Hi @hlky, this looks good! I think the newline kwarg is only needed on the writer file handle (mode="w"), though. On the reader file handles, universal newlines are already used, so setting newline="\n" will have no effect, and might even reduce compatibility (it will break if the input file has "\r\n" newlines): https://docs.python.org/3/library/functions.html#open

[hlky]

Thanks @Rocketknight1. .gitattributes will handle CRLF->LF if newline="\n" wasn't set on write but avoids the warning.

warning: in the working copy of 'src/transformers/models/siglip2/modeling_siglip2.py', CRLF will be replaced by LF the next time Git touches it

[Rocketknight1]

Yep, looks good to me now!