-
Notifications
You must be signed in to change notification settings - Fork 30.3k
🚨 Remove DoLa decoding strategy #40082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me, added two minor nits :) I've also checked the repo itself, and I'm quite happy with it!
👉 Sanity-check question: if you add trust_remote_code=True
on the mixin test (test_dola_decoding_sample
), do the tests still pass? Let's confirm this 🤗 (I see you did it in the integration tests 👍 )
👉 merging: we'll need to move the repo under transformers-community
before merging, let's take care of it tomorrow!
@manueldeprada happy with the new test! Feel free to merge 🤗 (I've also added DoLa to the collection in |
[For maintainers] Suggested jobs to run (before merge) run-slow: aria, csm, deepseek_v3, dia, gemma, gemma3n, git, granitemoe, granitemoeshared, llama, mistral, qwen2_5_omni, recurrent_gemma |
Removes Decoding by Contrasting Layers (DoLa) generation strategy from the codebase. Directs users to the
transformers-community/dola
repository.It has been a warning for a few releases, but now
trust_remote_code=True
is required to run DoLa generation.