Skip to content

Conversation

manueldeprada
Copy link
Contributor

@manueldeprada manueldeprada commented Aug 11, 2025

Removes Decoding by Contrasting Layers (DoLa) generation strategy from the codebase. Directs users to the transformers-community/dola repository.

It has been a warning for a few releases, but now trust_remote_code=True is required to run DoLa generation.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@manueldeprada manueldeprada requested a review from gante August 21, 2025 10:05
@manueldeprada manueldeprada marked this pull request as ready for review August 21, 2025 10:58
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, added two minor nits :) I've also checked the repo itself, and I'm quite happy with it!

👉 Sanity-check question: if you add trust_remote_code=True on the mixin test (test_dola_decoding_sample), do the tests still pass? Let's confirm this 🤗 (I see you did it in the integration tests 👍 )
👉 merging: we'll need to move the repo under transformers-community before merging, let's take care of it tomorrow!

@manueldeprada manueldeprada changed the title Removes DoLa decoding strategy 🚨 Remove DoLa decoding strategy Aug 25, 2025
@gante
Copy link
Member

gante commented Aug 25, 2025

@manueldeprada happy with the new test! Feel free to merge 🤗

(I've also added DoLa to the collection in transformers-community)

Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: aria, csm, deepseek_v3, dia, gemma, gemma3n, git, granitemoe, granitemoeshared, llama, mistral, qwen2_5_omni, recurrent_gemma

@manueldeprada manueldeprada merged commit ea8d9c8 into huggingface:main Aug 25, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants