Skip to content

[serve] add cors warnings #40112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2025
Merged

[serve] add cors warnings #40112

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f5061b
add cors warnings
gante Aug 12, 2025
8bbdd10
Update src/transformers/commands/serving.py
gante Aug 13, 2025
a485a17
Update src/transformers/commands/serving.py
gante Aug 13, 2025
ed4a2e4
Apply suggestions from code review
gante Aug 13, 2025
9d45a6a
make fixup
gante Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/transformers/commands/serving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,14 @@ def run(self):
allow_methods=["*"],
allow_headers=["*"],
)
logger.warning(
"WARNING: CORS allow origin is set to `*`. This is not recommended for production environments."
)
else:
logger.warning(
"NOTE: Some apps may require CORS. Consider launching the server with `--enable-cors` if you see "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.warning(
"NOTE: Some apps may require CORS. Consider launching the server with `--enable-cors` if you see "
logger.info(
"Some apps may require CORS. Consider launching the server with `--enable-cors` if you see "

Copy link
Member Author

@gante gante Aug 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info don't get shown by default, and I want this to be shown on transformers serve (otherwise, users will keep getting stuck)

"errors."
)

@app.post("/v1/chat/completions")
def chat_completion(request: dict):
Expand Down