[v5] Delete left traces of feature extractor #41321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zucchini-nlp
changed the title
zucchini-nlp
changed the title
|
[For maintainers] Suggested jobs to run (before merge) run-slow: blip, blip_2, chinese_clip, clip, clipseg, donut, flava, fuyu, git, idefics, layoutlmv2, layoutlmv3, layoutxlm, mgp_str, musicgen, nougat |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After rebasing #40793 and getting new changes on
TypedDict, I found out that some traces from feature extractor were still left. Thanks for type validation we can catch inconsistencies easily :)This PR goes over the deprecated properties as well and deletes them. Also it deletes
current_processorwhich was also deprecated for v5