Skip to content

Conversation

SunMarc
Copy link
Member

@SunMarc SunMarc commented Oct 3, 2025

What does this PR do?

This PR deprecates warmup_ratio. Instead we ask the user to use warmup_steps instead as we now allow passing float values. This is something that was already done for a few args like eval_steps .

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec
Copy link
Member

we use warmup_ratio a lot in our recipes/configs, but when I think about it, it might make more sense to use warmup_step instead., I'd be curious to hear the feedback of @edbeeching @lewtun on this.

This reverts commit cf4f9e7.
This reverts commit 1800beb.
@SunMarc
Copy link
Member Author

SunMarc commented Oct 6, 2025

we use warmup_ratio a lot in our recipes/configs, but when I think about it, it might make more sense to use warmup_step instead., I'd be curious to hear the feedback of @edbeeching @lewtun on this.

I don't mind keeping it if you think this will lead to too many complications !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants