Skip to content

Conversation

Sai-Suraj-27
Copy link
Contributor

What does this PR do?

Fixes raising of TypeError exception instead of ValueError for invalid type

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1 @ArthurZucker

@Rocketknight1
Copy link
Member

This seems okay, but please check the failing tests in the CI. It's likely that some tests are set up to catch certain errors, and the changed error has broken them!

Copy link
Contributor

github-actions bot commented Oct 6, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: evolla, gemma3n, lfm2_vl, ovis2, perception_lm, sam, sam2, sam2_video

@Sai-Suraj-27
Copy link
Contributor Author

@Rocketknight1 Yes, Updated the PR. Failing test seems un-related to the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants