Skip to content

Conversation

Haziq2006
Copy link

This PR adds a new training example under examples/3D_parallel.py that demonstrates a simple training loop with distributed (DDP/TP/PP) support.

Changes included:

-Fixed invalid docstring (""" instead of """:).

-Added fallback for local_rank in non-distributed setups.

-Wrapped dist.get_rank() and dist.destroy_process_group() with if dist.is_initialized().

-Lowered num_proc in datasets.map to avoid crashes on small machines.

-Integrated optional Weights & Biases tracking (--with_tracking).

-This script is intended to help users quickly test 3D parallelism setups with Hugging Face models.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

This PR adds a new training example under examples/3D_parallel.py that demonstrates a simple training loop with distributed (DDP/TP/PP) support. 

Changes included:

-Fixed invalid docstring (""" instead of """:).

-Added fallback for local_rank in non-distributed setups.

-Wrapped dist.get_rank() and dist.destroy_process_group() with if dist.is_initialized().

-Lowered num_proc in datasets.map to avoid crashes on small machines.

-Integrated optional Weights & Biases tracking (--with_tracking).

-This script is intended to help users quickly test 3D parallelism setups with Hugging Face models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant