Skip to content

Conversation

i3hz
Copy link

@i3hz i3hz commented Oct 6, 2025

What does this PR do?

This PR fixes a numerical regression bug in the vision positional embedding calculation that was introduced between transformers versions v4.54.1 and v4.55.1. The original change was made to improve exportability but resulted in a slight floating point difference.
The fix was applied to the base modular files (modular_idefics2.py and modular_idefics3.py) and then propagated to all dependent models via make fix-copies.

Fixes #41190

Before submitting

Who can review

@zucchini-nlp

Copy link
Contributor

github-actions bot commented Oct 6, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: idefics2, idefics3, smolvlm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in SmolVLM results in different vision embeddings
1 participant