-
Notifications
You must be signed in to change notification settings - Fork 30.7k
Correct numerical regression in vision embeddings #41374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[For maintainers] Suggested jobs to run (before merge) run-slow: idefics2, idefics3, smolvlm |
run-slow: idefics2, idefics3, smolvlm |
This comment contains run-slow, running the specified jobs: models: ['models/idefics2', 'models/idefics3', 'models/smolvlm'] |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
I'm struggling a bit to understand where exactly the tests have failed . I can see a test_model_parallel_beam_search test has failed . |
On my local machine after running python3 -m pytest -v -rsfE --make-reports=multi-gpu_run_models_gpu_models/smolvlm_test_reports tests/models/smolvlm I got the result : I don't have a multi gpu system so I'm not sure if that's why I have more skips |
@i3hz the only failing test is Btw for running locally you also need to set
|
@zucchini-nlp I ran the RUN_SLOW=1 pytest tests/models/smolvlm/test_modeling_smolvlm.py command . With these results The good news is that all three export tests passed successfully-
As for the failures -
Let me know what you think . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for verifying! Looks good to me, let's merge
What does this PR do?
This PR fixes a numerical regression bug in the vision positional embedding calculation that was introduced between
transformers
versions v4.54.1 and v4.55.1. The original change was made to improve exportability but resulted in a slight floating point difference.The fix was applied to the base modular files (
modular_idefics2.py
andmodular_idefics3.py
) and then propagated to all dependent models viamake fix-copies
.Fixes #41190
Before submitting
Pull Request section?
to it if that's the case. Regression in SmolVLM results in different vision embeddings #41190
Who can review
@zucchini-nlp