-
Notifications
You must be signed in to change notification settings - Fork 31.8k
[GLM-4.7] GLM-4.7-Flash Model Supoort #43031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Almost nothing to say but that we might want to go explicit for mlp type maybe? not a must its more for use @Cyrilvallez and @vasqu ?
src/transformers/models/glm4_moe_lite/configuration_glm4_moe_lite.py
Outdated
Show resolved
Hide resolved
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, glm4_moe, glm4_moe_lite |
ArthurZucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| - local: model_doc/xlstm | ||
| title: xLSTM | ||
| - local: model_doc/glm4_moe_lite | ||
| title: y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incorrect, could we replace it with e.g. glm4_moe_lite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this urgent to fix? I can wait and provide a new PR with the model introduction and these changes after I've completed the model description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not urgent, just something that should be fixed at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a PR here
GLM-Lite is the class updated for GLM-4.7-Flash, which adopts a different model architecture from GLM-4.7. The intermediate state was named GLM-Lite and has now been renamed to GLM-4.7-Flash. At the same time, a PR has been submitted to improve the documentation.