Skip to content

Fix get_number_of_image_tokens#43948

Merged
zucchini-nlp merged 3 commits intohuggingface:mainfrom
zucchini-nlp:get-num-vision-tokens
Feb 12, 2026
Merged

Fix get_number_of_image_tokens#43948
zucchini-nlp merged 3 commits intohuggingface:mainfrom
zucchini-nlp:get-num-vision-tokens

Conversation

@zucchini-nlp
Copy link
Member

What does this PR do?

Fixes get_num_of_image_tokens in idefics3 and adds a test. Aloong the way fixes a few more models

Reported in vllm-project/vllm#34358

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker
Copy link
Collaborator

tests/models/glm4v/test_image_processing_glm4v.py::Glm4vImageProcessingTest::test_get_number_of_image_patches_matches_slow_processor - AssertionError: 4 != 64 is related no? can you update / skip it

@zucchini-nlp
Copy link
Member Author

related, fixing and merging

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: chameleon, colpali, colqwen2, emu3, florence2, gemma3, glm46v, glm4v, idefics3, lighton_ocr, llava, llava_next, pixtral, qwen2_5_vl, smolvlm

@zucchini-nlp zucchini-nlp enabled auto-merge (squash) February 12, 2026 16:14
@zucchini-nlp zucchini-nlp merged commit 53a49c4 into huggingface:main Feb 12, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants